Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the -t option, which was reserved, to match bison and behave the same as --debug #504

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

ydah
Copy link
Member

@ydah ydah commented Jan 7, 2025

This PR change the -t option, which was reserved, to match bison, so that it works the same as --debug.

❯ bison -h
Usage: bison [OPTION]... FILE
: (snip)
Tuning the Parser:
  -L, --language=LANGUAGE          specify the output programming language
  -S, --skeleton=FILE              specify the skeleton to use
  -t, --debug                      instrument the parser for tracing
  ^^

… the same as `--debug`

This PR change the `-t` option, which was reserved, to match bison, so that it works the same as `--debug`.

```
❯ bison -h
Usage: bison [OPTION]... FILE
: (snip)
Tuning the Parser:
  -L, --language=LANGUAGE          specify the output programming language
  -S, --skeleton=FILE              specify the skeleton to use
  -t, --debug                      instrument the parser for tracing
  ^^
```
@ydah ydah merged commit 45720ab into ruby:master Jan 8, 2025
22 checks passed
@ydah ydah deleted the t-option branch January 8, 2025 09:27
yui-knk added a commit to yui-knk/lrama that referenced this pull request Jan 12, 2025
This reverts commit 45720ab, reversing
changes made to b65bc88.
@yui-knk
Copy link
Collaborator

yui-knk commented Jan 13, 2025

Note: After this commit is merged into master branch, test-ruby tasks take 60 min to complete (before and after).
This is because -t option is passed to lrama when ripper is build so that a lot of trace information is rendered.
-t option is not needed for ripper build then I stopped passing the option by ruby/ruby@84f0d2d.

@ydah
Copy link
Member Author

ydah commented Jan 13, 2025

Thank you so much 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants