Raise proper error at reference with no declared type #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure that this is a right fix; passing rule's name to |
When using reference with no declared type mistakenly, it raise `NoMethodError` with ``undefined method `s_value' for nil`` currently. Of course it is wrong code, but the message does not seem intentional. ``` ./lib/lrama/grammar/code.rb:77:in `block in translated_user_code' ./lib/lrama/grammar/code.rb:63:in `each' ./lib/lrama/grammar/code.rb:63:in `translated_user_code' ./lib/lrama/grammar/code.rb:14:in `translated_code' ./lib/lrama/grammar/rule.rb:30:in `translated_code' ```
|
I created #61. I hope https://github.com/ruby/lrama/pull/61/files#diff-f8748936dd72d99dbcf38b4e4c65325beb000c42d2c1779dd3ca1bcb57bdd0deR1375 covers all cases. Could you check it when you have time? |
|
Close in favor of #61. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using reference with no declared type mistakenly, it raise
NoMethodErrorwithundefined method `s_value' for nilcurrently.Of course it is wrong code, but the message does not seem intentional.