Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against Ruby 3.2.0 #101

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Test against Ruby 3.2.0 #101

merged 1 commit into from
Jan 14, 2023

Conversation

gfvcastro
Copy link
Member

No description provided.

@amatsuda
Copy link
Member

amatsuda commented Jan 8, 2023 •
edited
Loading

@gfvcastro Please do not change the existing '3.0'. As shown in this CI result:
https://github.com/ruby/net-http/actions/runs/3864905252/jobs/6588048949
GH Actions' YAML parser parses 3.0 as integer 3, then it ends up running the tests on "the latest released CRuby 3.x", i.e. 3.2.0 as of today.

See actions/runner#849 for more details.

@gfvcastro
Copy link
Member Author

Great catch, @amatsuda. I didn't know that.

@amatsuda amatsuda merged commit 8bde48d into ruby:master Jan 14, 2023
@gfvcastro gfvcastro deleted the test-ruby-3-2-0 branch January 15, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfvcastro @amatsuda