Restore ruby 2.5 support #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I know, this is the only stdlib that has dropped ruby 2.5, which hasn't yet reached its End of Life date. The motivation for this is that there's no gemified version of `net-http` that supports ruby 2.5, and that makes it hard for libraries depending on `net-http` to properly declare the dependency, since the only way is to drop support for ruby 2.5, which many maintainers will not yet want to do. The reason for wanting to declare the `net-http` dependency is mainly that it helps bundler & rubygems with avoiding double loads of different versions of `net-http` (the stdlib version and a higher gemified version). As far as I can observe from commit history, the only reason for dropping support for ruby 2.5 was that tests didn't pass, so I made them pass.
deivid-rodriguez
force-pushed
the
restore_2.5_support
branch
from
8dc9df4 to
00422fb
Compare
This was referenced Mar 25, 2021
olleolleolle
approved these changes
Jun 4, 2021
stanhu
added a commit
to stanhu/mail_room
that referenced
this pull request
Dec 14, 2021
This no longer builds due to the dependency of the net-http update. ruby/net-http#19 would solve this issue.
|
Based on precedents of other default gems, I don't think this is going to happen, so I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know, this is the only stdlib that has dropped ruby 2.5, which hasn't yet reached its End of Life date.
The motivation for this is that there's no gemified version of
net-httpthat supports ruby 2.5, and that makes it hard for librariesdepending on
net-httpto properly declare the dependency, since the only way is to drop support for ruby 2.5, which many maintainers will not yet want to do.The reason for wanting to declare the
net-httpdependency is mainly that it helps bundler & rubygems with avoiding double loads of different versions ofnet-http(the stdlib version and a higher gemified version). See for example ruby/net-imap#16.As far as I can observe from commit history, the only reason for dropping support for ruby 2.5 was that tests didn't pass, so I made them pass.