Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Accept-Encoding header on HEAD method #26

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

smaeda-ks
Copy link
Contributor

context: https://bugs.ruby-lang.org/issues/17835

Discussions are welcome. Thanks

Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me.

@jeremyevans jeremyevans requested a review from nurse June 15, 2021 18:25
@smaeda-ks
Copy link
Contributor Author

Just following up @jeremyevans @nurse
Could this be merged? Thanks

@jeremyevans
Copy link
Contributor

This is still OK with me. However, I'm not the net-http maintainer, so I think @nurse should approve this before it is merged.

@nurse nurse merged commit 3ffb4fe into ruby:master Nov 11, 2021
@nurse
Copy link
Member

nurse commented Nov 11, 2021

Sorry for late. This sounds reasonable and I merged this, thank you for your contribution!

@smaeda-ks smaeda-ks deleted the send-ae-on-head-request-method branch November 11, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants