Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the recommended name formal #60

Merged
merged 1 commit into from
May 20, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/net/http/exceptions.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ class Net::HTTPError < Net::ProtocolError
class Net::HTTPRetriableError < Net::ProtoRetriableError
include Net::HTTPExceptions
end
class Net::HTTPServerException < Net::ProtoServerError
# We cannot use the name "HTTPServerError", it is the name of the response.
class Net::HTTPClientException < Net::ProtoServerError
include Net::HTTPExceptions
end

# for compatibility
Net::HTTPClientException = Net::HTTPServerException
Net::HTTPServerException = Net::HTTPClientException # :nodoc:
# We cannot use the name "HTTPServerError", it is the name of the response.

class Net::HTTPFatalError < Net::ProtoFatalError
include Net::HTTPExceptions
Expand Down