Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Enhanced RDoc for Net::HTTPHeader #83

Merged
merged 2 commits into from
Dec 1, 2022
Merged

[DOC] Enhanced RDoc for Net::HTTPHeader #83

merged 2 commits into from
Dec 1, 2022

Conversation

BurdetteLamar
Copy link
Member

@BurdetteLamar BurdetteLamar commented Nov 29, 2022

PR to emphasize that setters are mostly about requests, while getters are mostly about responses:

  • Moved setter sections before getter sections; you do set/request before response/get.
  • Added introductory remark to setters section.
  • Added #add_field to setters section.
  • Added introductory remark to getters section.
  • Added #fetch to getters section.
  • Fine-tuned distinction between string field value and array field value (a few places).
  • Changed examples for getters to use a response object instead of a request object.

@BurdetteLamar BurdetteLamar added the documentation Improvements or additions to documentation label Nov 29, 2022
lib/net/http/header.rb Outdated Show resolved Hide resolved
lib/net/http/header.rb Outdated Show resolved Hide resolved
lib/net/http/header.rb Outdated Show resolved Hide resolved
lib/net/http/header.rb Outdated Show resolved Hide resolved
@peterzhu2118 peterzhu2118 merged commit 1ea5004 into ruby:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

2 participants