🐛 Fix NAMESPACE parsing (and other ♻️ refactoring) #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I misread or misunderstood the spec when I first implemented this... I wrongly inserted SP-delimiters. Most servers don't list more than one namespace, so probably very few noticed the bug! Also: * ♻️ Rewrote using "new parser style" to more directly imitate the ABNF. * ⚡️ Small but measurable performance improvement. * ♻️ Add ParserUtils::Generator#def_token_matchers for quoted, string, nil, tagged_ext_label, etc. * ♻️ Move atom, astring, nstring, etc to top, so they can be aliased. * ♻️ Use NIL in nstring, nquoted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
n.b, this was split off from #104, which was too big for a single PR.
I misread or misunderstood the spec when I first implemented this... I wrongly inserted SP-delimiters. Most servers don't list more than one namespace, so probably very few noticed the bug!
Also: