Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧵 Synchronize @responses update in thread_internal #116

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

nevans
Copy link
Collaborator

@nevans nevans commented Feb 24, 2023

This was the only unsynchronized access of @responses that I saw, so long as the private record_responses method is only called inside the mutex, or before the initializer returns and the receiver thread has started.

@nevans nevans merged commit e0b3620 into master Mar 2, 2023
@nevans nevans deleted the synchronize-thread-responses branch March 2, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant