⚡ Simpler, faster response-data parser
#201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several versions were tried: `Hash[name].call`, `case name when regexp`, `case name.to_sym`, etc, but benchmarks clearly showed `case string.upcase when "str"` as fastest. This change also documents which RFC covers which response types.
Use `peek_re(RE_RESPONSE_TYPE)` and the `TAGGED_EXT_LABEL` regexp, to unify numeric and non-numeric types in the same case stmt. This is much simpler than two tier version, but I don't have benchmarks as to whether or not this version of the code performs any better. Add aliases for nz-number. Not validating that the numbers are within their allowed range, for now at least.
The case statement is sorted _roughly_ in the order of frequency... but I need to collect more data to reliably make a claim about that. In the meantime, this order made sense to me... more or less. Current standard (both RFC3501 and RFC9051) responses are sorted first, and deprecated, uncommon, unsupported, etc responses are sorted last.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
response_dataandnumeric_responseinto a single case statement, using a regexp for lookahead.