Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add fetch support for BINARY and BINARY.SIZE #207

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

nevans
Copy link
Collaborator

@nevans nevans commented Oct 24, 2023

Lex and parse LITERAL8, string8, nstring8.

The BINARY extension isn't fully supported; that requires updates to the APPEND command. But this should be sufficient for IMAP4rev2, which only requires the FETCH part of the extension.

Related:

@nevans nevans force-pushed the parser/fetch-BINARY branch from d84b39a to 164c099 Compare October 26, 2023 03:31
@nevans nevans changed the title ✨ Add BINARY FETCH support ✨ Add fetch support for BINARY and `BINARY.SIZÈ Oct 26, 2023
@nevans nevans changed the title ✨ Add fetch support for BINARY and `BINARY.SIZÈ ✨ Add fetch support for BINARY and BINARY.SIZE Oct 26, 2023
@nevans nevans added the IMAP4rev2 Requirement for IMAP4rev2, RFC9051 label Oct 26, 2023
@nevans nevans force-pushed the parser/fetch-BINARY branch 2 times, most recently from 6f4ef66 to ac05d06 Compare October 30, 2023 01:30
@nevans nevans marked this pull request as draft November 3, 2023 18:30
@nevans nevans force-pushed the parser/fetch-BINARY branch 5 times, most recently from 73ae8ee to adfd8b7 Compare November 10, 2023 13:46
Lex and parse LITERAL8, string8, nstring8.
Add section_binary and section_part

The BINARY extension isn't _fully_ supported; that requires updates to
the APPEND command.  But this should be sufficient for IMAP4rev2, which
only requires the FETCH part of the extension.
@nevans nevans force-pushed the parser/fetch-BINARY branch from adfd8b7 to a675270 Compare November 10, 2023 14:02
@nevans nevans marked this pull request as ready for review November 10, 2023 14:03
@nevans nevans merged commit 3410e14 into ruby:master Nov 10, 2023
11 checks passed
@nevans nevans deleted the parser/fetch-BINARY branch November 10, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IMAP4rev2 Requirement for IMAP4rev2, RFC9051
Development

Successfully merging this pull request may close these issues.

RFC3516 (2003): BINARY FETCH extensions (included in IMAP4rev2)
1 participant