Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant calls in sort_internal and thread_internal #251

Merged
merged 2 commits into from
Dec 24, 2023

Conversation

gobijan
Copy link
Contributor

@gobijan gobijan commented Dec 14, 2023

sort_internal and thread_internal have an else statement that can be removed because normalize_searching_criteria(search_keys) is called anyways after the case.

sort_internal and thread_internal have an else statement that can be
removed because normalize_searching_criteria(search_keys) is called
anyways after the case.
@nevans
Copy link
Collaborator

nevans commented Dec 20, 2023

Thanks! I was looking at the normalize_searching_criteria code just last night, in order to finish up a PR for #115, and I was puzzling over why it might be called twice like that! I hadn't realized there was a PR waiting to fix it. 😆 Maybe it was an accident during 080bd61? It's lasted twenty years!

Could you update your PR to match the style search_internal? We don't need to normalize_searching_criteria at all when the criteria is just RawData.

@gobijan
Copy link
Contributor Author

gobijan commented Dec 20, 2023

Done.
20 years in software is quite some time! :)

@nevans nevans merged commit d69ebad into ruby:master Dec 24, 2023
1 of 11 checks passed
nevans added a commit that referenced this pull request Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants