✅ Setup simplecov #328
Merged
✅ Setup simplecov #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevans
force-pushed
the
simplecov
branch
3 times, most recently
from
a1bb9ef to
65c9f43
Compare
|
WTH GitHub? I didn't close this? |
nevans
force-pushed
the
simplecov
branch
2 times, most recently
from
3fed58a to
9f7a79f
Compare
It took me a while to figure out that the simplecov-check-action requires extra permissions, and even then it still needs a GitHub App to work on `pull_request` events. I'm okay with only running it on `push` events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#327 and bugs like it can be embarrassing! 😞 I really thought I had a test for that (maybe I did, and it got lost during a rebase or refactoring?).
Adding simplecov will make it easier to hunt these sorts of bugs down and prevent them.