Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make simplecov-json as optional dependency #344

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Oct 30, 2024

In ruby/ruby repository, we can't use simplecov-json for make test-bundled-gems.

https://github.com/ruby/ruby/actions/runs/11569147158/job/32202320346#step:14:163

I added workaround for that. I'm happy to release v0.5.1 with this.

Copy link
Collaborator

@nevans nevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

I originally considered only loading simplecov if an ENV var is present. I like this better. 🙂

@nevans nevans merged commit 5409e1a into master Oct 30, 2024
22 checks passed
@nevans nevans deleted the make-simplecov-json-optional branch October 30, 2024 15:08
@nevans
Copy link
Collaborator

nevans commented Oct 30, 2024

@hsbt I could also make the release, but I don't think you've made a release since I added Trusted Publishing. So it's probably good for you to do it. All you should need to do is:

  1. bump the version number (same as it ever was)
  2. push the tag
  3. Find the workflow run and approve the deployment (and wait a couple of minutes).
  4. The GitHub release notes should be auto-generated, and saved as a draft.

Let me know if you hit any issues. Obviously, you can still just create a release the old way, if anything goes wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants