✨ Coerce Set, :*, #to_sequence_set search args into sequence-set
#351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also deleted redundant `private_const` argument
This adds tests for * String => quoted string * Range => sequence-set * -1 => sequence-set * sequence-set string with "*" => quoted string
This format simplifies updating the docs in later commits.
This will be useful later, for recursively inspecting arrays. Also, the three different cases are split up, because we'll probably add extra limitations on `Range` and `Array` in a different PR.
This catches invalid args slightly sooner.
nevans
changed the title
Set, :*, and responds to #to_sequence_set search args into sequence-setSet, :*, #to_sequence_set search args into sequence-set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was extracted from #345. This adds types which will be converted into SequenceSet, so that PR can focus only on not converting a few types to SequenceSet.