Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled windows-latest on GHA #359

Merged
merged 2 commits into from
Nov 30, 2024
Merged

Enabled windows-latest on GHA #359

merged 2 commits into from
Nov 30, 2024

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Nov 29, 2024

@nevans I'm working to enable to test with Windows at ruby/ruby#12193

In net-imap, only test_starttls_unknown_ca is failing at that pull-request. I make to skip that test with Windows. And I added windows-latest to our CI.

Copy link
Collaborator

@nevans nevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about why that test is failing for Windows. But I don't have an easy way to run Windows locally right now, and it's better to get all of the other tests in CI for Windows than to delay for this one failure.

@nevans nevans merged commit 89d6c04 into master Nov 30, 2024
30 checks passed
@nevans nevans deleted the enable-windows-test branch November 30, 2024 02:43
@hsbt
Copy link
Member Author

hsbt commented Dec 3, 2024

I'm curious about why that test is failing for Windows.

I'm also curious only this test failed at Windows. I could reproduce this failure with my Windows environment. I added this issue to my (long) TODO list 👌

@nevans
Copy link
Collaborator

nevans commented Dec 3, 2024

I'm curious about why that test is failing for Windows.

I'm also curious only this test failed at Windows. I could reproduce this failure with my Windows environment. I added this issue to my (long) TODO list 👌

No prob! I might try to get one of my coworkers to try to reproduce it. You've got bigger issues to worry about. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants