Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XOAUTH2 authenticator #63

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Conversation

ssunday
Copy link
Contributor

@ssunday ssunday commented Sep 22, 2022

Thanks to https://github.com/nfo/gmail_xoauth for doing the heavy lifting and changing the license. 💪🏻

I tested it with a Microsoft 365 account. I would appreciate someone verifying it works with Gmail too to make sure.

Let me know if there's anything else that I can do to get this in 🙏🏻

@ssunday
Copy link
Contributor Author

ssunday commented Sep 22, 2022

Part of #12

@ssunday ssunday changed the title Add XOAuth2 authenticator Add XOauth2 authenticator Sep 22, 2022
@ssunday ssunday changed the title Add XOauth2 authenticator Add XOAUTH2 authenticator Sep 22, 2022
@hsbt
Copy link
Member

hsbt commented Sep 28, 2022

@ssunday Can you rebase from the current master?

@ssunday ssunday force-pushed the add-xoauth2-authenticator branch from 79df129 to e2593e6 Compare September 28, 2022 12:49
@ssunday
Copy link
Contributor Author

ssunday commented Sep 28, 2022

@hsbt rebased

@ssunday ssunday requested a review from shugo September 29, 2022 00:12
Copy link
Member

@shugo shugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine. Thank you!

@shugo shugo merged commit a0d6724 into ruby:master Sep 29, 2022
@ssunday ssunday deleted the add-xoauth2-authenticator branch September 29, 2022 12:40
@nevans
Copy link
Collaborator

nevans commented Sep 29, 2022

thanks! I'd started on this a while ago and got completely sidetracked. thanks again!

Additionally, thanks for the reminder that I'd forgotten about it. No promises, but I'll try to finish up my ANONYMOUS, EXTERNAL, OAUTHBEARER, and SCRAM-* PRs this week.

@Neustradamus
Copy link

@ssunday: Thanks for your PR!

@nevans: Can not wait ^^

@nevans nevans added the SASL 🔒 Authentication and authentication mechanisms label Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SASL 🔒 Authentication and authentication mechanisms
Development

Successfully merging this pull request may close these issues.

5 participants