Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes "bundle exec rake" clash with test/unit #67

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Conversation

nevans
Copy link
Collaborator

@nevans nevans commented Oct 14, 2022

When multiple versions of "test/unit" are installed, the Gemfile.lock can be out of sync with "test/unit" version selected without bundler. When that happens, "bundle exec rake" fails, even when "rake" passes.

This can generally be fixed by simply running "bundle update" so the lockfile has the latest version, too. And the lockfile is gitignored so this doesn't affect CI. But, the error can be confusing and waste time.

When multiple versions of "test/unit" are installed, the Gemfile.lock
can be out of sync with "test/unit" version selected without bundler.
When that happens, "bundle exec rake" fails, even when "rake" passes.

This can generally be fixed by simply running "bundle update" so the
lockfile has the latest version, too.  And the lockfile is gitignored so
this doesn't affect CI.  But, the error can be confusing and waste time.
@nevans nevans requested a review from hsbt October 14, 2022 18:05
@nevans
Copy link
Collaborator Author

nevans commented Oct 14, 2022

@hsbt I would have put require "bundler/setup" into test/lib/helper.rb, but I thought it was synchronized with rake sync_tool. But I see now that rake sync_tool doesn't touch that file. Doing it here should be fine too, I think.

@nevans nevans changed the title Fixes "bundle exec rake", clash with test/unit Fixes "bundle exec rake" clash with test/unit Oct 14, 2022
@hsbt hsbt merged commit 1e80875 into master Oct 20, 2022
@hsbt hsbt deleted the fix-bundle-exec-rake branch October 20, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants