fix static symbol resolution #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a prefactor so we can compile shared and static objects separately in a subsequent commit.
but also offer a V=1 option for verbose mode
This was referenced Jul 1, 2023
flavorjones
added a commit
to flavorjones/yarp
that referenced
this pull request
Jul 9, 2023
This reverses the convention introduced in ruby#1069, and requires `YP_EXPORT_SYMBOLS` to be defined at compile-time when building a shared library. See related ruby#1111 which describes a symbol leakage problem in Ruby 3.3 (ruby head) that this commit, once merged upstream into Ruby, should address. Note that the tests introduced in a previous commit ensure that the static archive and shared objects are all being created correctly after this change.
flavorjones
added a commit
to flavorjones/yarp
that referenced
this pull request
Jul 9, 2023
This reverses the convention introduced in ruby#1069, and requires `YP_EXPORT_SYMBOLS` to be defined at compile-time when building a shared library. See related ruby#1111 which describes a symbol leakage problem in Ruby 3.3 (ruby head) that this commit, once merged upstream into Ruby, should address. Note that the tests introduced in a previous commit ensure that the static archive and shared objects are all being created correctly after this change. Co-authored-by: Aaron Patterson <tenderlove@ruby-lang.org>
flavorjones
added a commit
to flavorjones/yarp
that referenced
this pull request
Jul 11, 2023
This reverses the convention introduced in ruby#1069, and requires `YP_EXPORT_SYMBOLS` to be defined at compile-time when building a shared library. See related ruby#1111 which describes a symbol leakage problem in Ruby 3.3 (ruby head) that this commit, once merged upstream into Ruby, should address. Note that the tests introduced in a previous commit ensure that the static archive and shared objects are all being created correctly after this change. Co-authored-by: Aaron Patterson <tenderlove@ruby-lang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1067
This PR introduces separate object files (and build directories) for the dll (
librubyparser.so) and the static archive (librubyparser.a) to ensure the dll makes public symbols public and the static archive does not.I've also made the Makefile much quieter by default, but provide support for a
V=1argument for verbose mode (just like mkmf Makefiles).This makes the difference between (uppercase
T):and (lowercase
t):