Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useless useless feedback #137

Closed
marcandre opened this issue Aug 11, 2020 · 3 comments
Closed

useless useless feedback #137

marcandre opened this issue Aug 11, 2020 · 3 comments
Assignees

Comments

@marcandre
Copy link
Member

$ racc -l -v -o lib/rubocop/ast/node_pattern/parser.racc.rb lib/rubocop/ast/node_pattern/parser.y 
1 useless nonterminals
2 useless rules
1 shift/reduce conflicts

Ok, so I screwed something up. But which useless nonterminals? Which useless rules? And maybe the shift/reduce conflict is hard to express, but still...

@marcandre
Copy link
Member Author

Sorry for the noise, just noticed the .output file...

@zenspider zenspider reopened this Aug 13, 2020
@zenspider
Copy link
Collaborator

Eh... I think it is still valid critique... Wanna do a PR that at least changes the messaging to say "generate and look at the .output file" ?

@marcandre
Copy link
Member Author

Sure...

@marcandre marcandre self-assigned this Aug 14, 2020
marcandre added a commit to marcandre/racc that referenced this issue Aug 14, 2020
marcandre added a commit to marcandre/racc that referenced this issue Aug 14, 2020
marcandre added a commit to marcandre/racc that referenced this issue Aug 14, 2020
marcandre added a commit to marcandre/racc that referenced this issue Aug 14, 2020
marcandre added a commit to marcandre/racc that referenced this issue Aug 14, 2020
marcandre added a commit to marcandre/racc that referenced this issue Aug 14, 2020
marcandre added a commit to marcandre/racc that referenced this issue Aug 19, 2020
marcandre added a commit to marcandre/racc that referenced this issue Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants