-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "test-unit-ruby-core" development dependency #227
Conversation
Can you update with that? |
Properly specify gem dependencies
This allows broader eccosystem to benefit from the dependencies, such as rubygems.org will properly report, that there is some library using "test-unit-ruby-core".
I have tried. However, I am not clear how #229 is supposed to work, because I have precisely zero knowledge about dependabot. Maybe I should have left the |
Ah, sorry. dependabot is not support |
Development dependencies are only relevant for the people who are working on (or repackaging)
The Gemfile is an acceptable and proper place to specify development dependencies. I think it is completely appropriate for us to declare them where and how it's convenient and sustainable for us.
Dependabot is a tool that helps open source maintainers ensure that a) dependencies are updated when new versions are available, b) and that CI still passes with those updated dependencies. Particularly for maintainers of many gems, this automation is very valuable for avoiding bitrot. @voxik I'm not sure what outcome you want from this change. |
I was wondering, why would somebody want to introduce https://rubygems.org/gems/test-unit-ruby-core/reverse_dependencies But this page says nothing. Also, generally, locking development dependencies might make upstream life easier, but it does downstream (such as Fedora) life harder. I am quite sure that the test suite can be tuned to work with specific versions, but we don't necessarily have them downstream. |
We should keep to use Gemfile, not gemspec. |
Specifically for this reason, there were two commits. I wish you have accepted at least the "Add "test-unit-ruby-core" development dependency" commit. |
Apart from properly specifying gem dependencies, this also allows to see on rubygems.org that there actually is some user of
test-unit-ruby-core
gem.Maybe the
Gemfile
should also use thegemspec
directive.