Make space trimming consistent for all task arguments. Fixes #260

ruby · Feb 23, 2018 · 15f9169 · 15f9169
1 parent 25c29b6
commit 15f9169
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/rake/application.rb b/lib/rake/application.rb
@@ -172,7 +172,7 @@ def parse_task_string(string) # :nodoc:
       args = []
 
       begin
-        /((?:[^\\,]|\\.)*?)\s*(?:,\s*(.*))?$/ =~ remaining_args
+        /\s*((?:[^\\,]|\\.)*?)\s*(?:,\s*(.*))?$/ =~ remaining_args
 
         remaining_args = $2
         args << $1.gsub(/\\(.)/, '\1')

diff --git a/test/test_rake_task_argument_parsing.rb b/test/test_rake_task_argument_parsing.rb
@@ -32,8 +32,8 @@ def test_two_arguments
     assert_equal ["one", "two"], args
   end
 
-  def test_can_handle_spaces_between_args
-    name, args = @app.parse_task_string("name[one, two,\tthree , \tfour]")
+  def test_can_handle_spaces_between_all_args
+    name, args = @app.parse_task_string("name[ one , two ,\tthree , \tfour ]")
     assert_equal "name", name
     assert_equal ["one", "two", "three", "four"], args
   end