Represent a TaskArgument object such that it's not confused with a hash. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I prefer this inspection message. Thanks! |
er0ck
pushed a commit
to er0ck/rototiller
that referenced
this pull request
Apr 11, 2017
* acceptance previously showed a bug we had against rake 12 * really rake 12 just clarified how to use arguments to tasks so they aren't confused with hashes: ruby/rake#171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ta = Rake::TaskArguments.new([:a, :b, :c], [1, 2, 3])Currently
puts ta # {:a=>1, :b=>2, :c=>3}Proposal
puts ta # #<Rake::TaskArguments a: 1, b: 2, c: 3>Why?
The current implementation leads one to believe they are working with a hash. This can lead to some confusion if you try doing something like
ta.a = 'one'which will silently ignore the assignment.In addition, I think
def_methodis preferable tomethod_missingto create accessors. That wayta.a = 'one'would generate aNoMethodError. Thoughts?Shoutout to @eric-hu, with whom I discovered this issue.