Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #246] Don't run file tasks needlessly (2nd attempt) #257

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

grzuy
Copy link
Contributor

@grzuy grzuy commented Feb 22, 2018

Second attempt at fixing #246.

@grzuy grzuy changed the title [Fixes #246] Don't run file tasks needlessly [Fixes #246] Don't run file tasks needlessly (2nd attempt) Feb 22, 2018
@grzuy
Copy link
Contributor Author

grzuy commented Mar 27, 2018

I solved conflicts with master and updated this PR.

@grzuy
Copy link
Contributor Author

grzuy commented Apr 4, 2018

Code Climate is showing an issue to fix, apparently because one of the lib/rake/task.rb method became "too large" because of a couple of lines added as part of this PR.

@rake-maintainers How do you handle these cases? Should I attempt to fix the issue as part of this PR? Or you handle those refactors as separate PRs? I checked Code Climate issue and I already had some ideas on how to refactor, but wanted to ask first given it might end up being not a simple refactor.

Thank you.

prereq_task.timestamp > stamp
end
}
prerequisite_tasks.any? { |task| task.timestamp > stamp }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’re removing functionality here like the rake --build-all flag and application scoping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants