-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rake test loader swallowing useful error information #367
Conversation
eef4f7e
to
bef15b8
Compare
Big 👍 from me :) |
Hello rake maintainers, what do you think about this? |
bef15b8
to
c955a5a
Compare
I was thinking that maybe this changeset appears to have too many changes. Unfortunately it looks more complicated than it is due to trying to keep consistent indentation. Here's the diff without whitespace, which should make reviewing this easier: https://github.com/ruby/rake/pull/367/files?w=1. The idea is that instead of wrapping any |
FYI I asked who are the maintainers of rake. Maybe @hsbt could review (looking at recent merges)? |
I'm not in a hurry at all to get this PR reviewed, I imagine how busy maintainers must be. I just thought a comment trying to aid a future review could be helpful :) |
I run into this again. I tried to run actionmailbox test suite and got this:
It's imposible to figure out what's going on 😞. With this PR I get this:
I don't yet know what's going on, but it gives me better information to start digging. @hsbt Let me know if there's something I can do to get this reviewed 💪. |
c955a5a
to
17e69a5
Compare
I got a bug report in bundler where the end user error being printed was like this:
This error is very unhelpful about what's going on.
After debugging, I found that rake was swallowing useful information about the error, and also incorrectly stating that a file named "pry" was missing.
This changeset should fix the problem and now
rake
gives more useful information: