Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chained extensions #39

Merged
merged 4 commits into from
Apr 18, 2017
Merged

Chained extensions #39

merged 4 commits into from
Apr 18, 2017

Conversation

pjump
Copy link

@pjump pjump commented Apr 11, 2015

rules such as

rule ".min.js" => ".js" do |t|
end

didn't work because Rake would simple replace the js part of".min.js" with ".js", creating a cyclic dependency. This PR makes rules like this work by always making sure the whole target pattern of is replaced, rather than just the very final extension.

All tests green. A test for the new feature added.

@pjump
Copy link
Author

pjump commented Apr 11, 2015

On a somewhat unrelated topic, does anyone know how to gemify this repo so I can install it?

@pjump
Copy link
Author

pjump commented Jun 3, 2015

Any opinion on this?

@hsbt
Copy link
Member

hsbt commented Jan 6, 2017

@pjump Sorry to my late response. I agreed to merge your proposal.

@hsbt hsbt self-requested a review January 6, 2017 05:29
@@ -10,6 +10,7 @@ class TestRakeRules < Rake::TestCase
OBJFILE = "abc.o"
FOOFILE = "foo"
DOTFOOFILE = ".foo"
MINFILE = 'abc.min.o'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you align = indentation?

@hsbt hsbt merged commit 252ad9e into ruby:master Apr 18, 2017
unasuke added a commit to unasuke/mail that referenced this pull request Apr 12, 2018
In Rake v12.1.0 or higher, the algorithm of resolve file dependency
was changed in ruby/rake#39 .

Then rake task "ragel:generate" is works incorrectry that require
wrong ragel source file.
As the example, rake resolves "lib/mail/parsers/address_lists_parser.rb"
needs "lib/mail/parsers/address_lists.rl", but this file is not exist.

Therefore, fixed that to pass full path of the ragel source file
to rule.
unasuke added a commit to unasuke/mail that referenced this pull request Apr 12, 2018
In Rake v12.1.0 or higher, the algorithm of resolve file dependency
was changed in ruby/rake#39 .

Then rake task "ragel:generate" is works incorrectry that require
wrong ragel source file.
As the example, rake resolves "lib/mail/parsers/address_lists_parser.rb"
needs "lib/mail/parsers/address_lists.rl", but this file is not exist.

Therefore, fixed that to pass full path of the ragel source file
to rule.
jeremy pushed a commit to mikel/mail that referenced this pull request Apr 13, 2018
In Rake v12.1.0 or higher, the algorithm of resolve file dependency
was changed in ruby/rake#39 .

Then rake task "ragel:generate" is works incorrectry that require
wrong ragel source file.
As the example, rake resolves "lib/mail/parsers/address_lists_parser.rb"
needs "lib/mail/parsers/address_lists.rl", but this file is not exist.

Therefore, fixed that to pass full path of the ragel source file
to rule.
composerinteralia added a commit to composerinteralia/mail that referenced this pull request Mar 10, 2021
Currently the ragel:svg task is broken. We need to use the full path
because of a change to Rake in ruby/rake#39.

We already changed this for the ragel:generate task in
mikel@20ffe29
jeremy pushed a commit to mikel/mail that referenced this pull request Mar 11, 2021
Currently the ragel:svg task is broken. We need to use the full path
because of a change to Rake in ruby/rake#39.

We already changed this for the ragel:generate task in
20ffe29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants