Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder conditions of needed? #433

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reorder conditions of needed? #433

wants to merge 1 commit into from

Conversation

jgomo3
Copy link

@jgomo3 jgomo3 commented Jun 17, 2022

  1. Asking for a setting option is less expensive than tree transversal on dependant tasks.
  2. out_of_date? should care about "date" concepts, and not concerning about "build_all" option.

Reordering allows us to remove the "build_all" check in the out_of_date, achieving the quality statement in the second item of the previous list.

Suddenly, there is no need to make a distinction between FileTask or other tasks.

1. Asking for a setting option is less expensive than tree transversal on dependant tasks.
2. `out_of_date?` should care about "date" concepts, and not concerning about "build_all" option.

Reordering allows us to remove the "build_all" check in the out_of_date, achieving the quality statement in the second item of the previous list.

Suddenly, there is no need to make a distinction between FileTask or other tasks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant