Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eagerly require set in thread_pool.rb #440

Merged
merged 1 commit into from
Jul 20, 2022

Commits on Jul 19, 2022

  1. Eagerly require set in thread_pool.rb

    Lazily requiring it in this matter can break rake whenever
    a rake task limits access to the file system.  For example:
    
    ```ruby
    task :default do
      Dir.chroot Dir.pwd
    end
    ```
    
    One reason to lazily require this is to save on memory, but
    since Rake::Application appears to always use a thread pool
    (Rake::Application#run -> top_level -> run_with_threads ->
    thread_pool), it doesn't looks like lazily requiring actually
    saves memory in this case.
    jeremyevans authored and hsbt committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    4d3b5d7 View commit details
    Browse the repository at this point in the history