Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern matching support for arguments #515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rgarner
Copy link

@rgarner rgarner commented Sep 18, 2023

Implement Rake::TaskArguments#deconstruct_keys. This means in an idiomatic ruby 3.x rake task we can use rightward assignment to say:

task :get, %i[tenant id] do |_t, args|
  args => {tenant:, id:}
  ...
end

... and omit the .to_h from args, raising NoMatchingPatternError if either of the two params is absent from the task args.

@hsbt hsbt force-pushed the task-arguments-deconstruct-keys branch from 23fa4d4 to bc17eee Compare March 15, 2024 00:40
@rgarner rgarner force-pushed the task-arguments-deconstruct-keys branch 3 times, most recently from 5b94216 to 9ca8f32 Compare April 2, 2024 09:49
Implement `Rake::TaskArguments#deconstruct_keys` for use in Ruby 3.1
and up. This means in an idiomatic rake task we can use rightward
assignment to say:

```
task :get, %i[tenant id] do |_t, args|
  args => {tenant:, id:}
  ...
end
```

... and omit the `.to_h` from `args`, raising `NoMatchingPatternError`
if either of the two params is absent from the task args.
@rgarner rgarner force-pushed the task-arguments-deconstruct-keys branch from 9ca8f32 to cbd2e35 Compare April 2, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants