Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update post line comment #381

Merged
merged 1 commit into from
Aug 29, 2020
Merged

Update post line comment #381

merged 1 commit into from
Aug 29, 2020

Conversation

sbeckeriv
Copy link
Contributor

Dearest Reviewer,

This is the only post line comment I have found so far. Per the syntax file they are not allowed. I have moved it up with the comments above. I think this
comment is more suited to this level of comments. If we were to show the comment above inline with code the monomorphic detail would be useful.

Thank you for your time and work on this project.
Dictated but not reviewed,
Becker

Dearest Reviewer,

This is the only post line comment I have found so far. Per the syntax file they are not allowed. I have moved it up with the comments above. I think this
comment is more suited to this level of comments. If we were  to show the comment above inline with code the monomorphic detail would be useful.

Thank you for your time and work on this project.
Dictated but not reviewed, 
Becker
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(It was intentional because the comment is not included in the original RDoc. But making it in the doc would make sense!)

@soutaro soutaro merged commit 4f37f49 into ruby:master Aug 29, 2020
@sbeckeriv sbeckeriv deleted the patch-3 branch November 9, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants