Allow installing RDoc from a git source #1113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
commented
May 29, 2024
| task :generate do | ||
| unless ENV.key?('BUNDLE_GEMFILE') | ||
| Gem.install 'racc', '> 1.4.10' | ||
| Gem.install 'kpeg', '>= 1.3.3' |
There was a problem hiding this comment.
@colby-swandale do you know if there's any rubygems API to better handle these dependencies without bundler?
There was a problem hiding this comment.
Could you expand the context where Bundler wouldn't be available?
There was a problem hiding this comment.
Bundler will be available, but this will be executed in 2 scenarios:
- When a developer runs
rake generate(or any tasks that depend on it) manually - When a user installs RDoc through git source
In the later case, I want to avoid installing all of RDoc's development dependencies as most of them aren't needed for generating the missing files.
nobu
reviewed
May 29, 2024
nobu
reviewed
May 29, 2024
Co-authored-by: Vinicius Stock <vinistock@users.noreply.github.com>
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
|
@nobu Thanks for the suggestions 👍 |
|
@nobu Would you mind giving this another look? If you're not against it, I'd like to give it a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements option 2 in #1107, which is to use
extconf.rbto conditionally runrake generatewhen the gem is installed as a git source.To make sure the target machine has the required dependencies for the generation, I modified
rake generateto conditionally install thekpegandracc.