Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document is not a Comment. Document shouldn't be assigned to code_object.comment #1210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Document is not a Comment. Document shouldn't be assigned to code_object.comment #1210

wants to merge 1 commit into from

Commits on Nov 18, 2024

  1. Document is not a Comment. Document shouldn't be assigned to code_obj… 

    …ect.comment

CodeObject#comment is normally String or Comment, but Marshal.dump and load creates CodeObject with comment=Document.
Some method requires Document stored in CodeObject#comment, some requires Comment.
We should stop mixing Document with Comment because it is mixing huge complexity and potential bugs to RDoc codebase.
    @tompng
    tompng committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    7a297e8 View commit details
    Browse the repository at this point in the history