Change Reline.add_dialog_proc(name, nil) to properly remove dialog_proc

ruby · Apr 13, 2023 · 4d3ccb0 · 4d3ccb0
1 parent 127a84d
commit 4d3ccb0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/reline.rb b/lib/reline.rb
@@ -166,9 +166,13 @@ def dig_perfect_match_proc=(p)
 
     DialogProc = Struct.new(:dialog_proc, :context)
     def add_dialog_proc(name_sym, p, context = nil)
-      raise ArgumentError unless p.respond_to?(:call) or p.nil?
       raise ArgumentError unless name_sym.instance_of?(Symbol)
-      @dialog_proc_list[name_sym] = DialogProc.new(p, context)
+      if p.nil?
+        @dialog_proc_list.delete(name_sym)
+      else
+        raise ArgumentError unless p.respond_to?(:call)
+        @dialog_proc_list[name_sym] = DialogProc.new(p, context)
+      end
     end
 
     def dialog_proc(name_sym)

diff --git a/test/reline/test_reline.rb b/test/reline/test_reline.rb
@@ -321,6 +321,9 @@ def test_add_dialog_proc
     d = Reline.dialog_proc(:test_proc)
     assert_equal(dummy_proc_2, d.dialog_proc)
 
+    Reline.add_dialog_proc(:test_proc, nil)
+    assert_nil(Reline.dialog_proc(:test_proc))
+
     l = lambda {}
     Reline.add_dialog_proc(:test_lambda, l)
     d = Reline.dialog_proc(:test_lambda)
@@ -331,6 +334,7 @@ def test_add_dialog_proc
     assert_raise(ArgumentError) { Reline.add_dialog_proc(:error, 42) }
     assert_raise(ArgumentError) { Reline.add_dialog_proc(:error, 'hoge') }
     assert_raise(ArgumentError) { Reline.add_dialog_proc('error', proc {} ) }
+    assert_raise(ArgumentError) { Reline.add_dialog_proc('error', nil) }
 
     dummy = DummyCallbackObject.new
     Reline.add_dialog_proc(:dummy, dummy)