Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dialog with autocomplete #318

Merged
merged 41 commits into from
Aug 29, 2021
Merged

Implement dialog with autocomplete #318

merged 41 commits into from
Aug 29, 2021

Conversation

aycabta
Copy link
Member

@aycabta aycabta commented Aug 25, 2021

No description provided.

aycabta added 29 commits August 17, 2021 19:21
@aycabta
Implement dialog with autocomplete callback
1401d61
@aycabta
Remove an unnecessary variable
5435c1a
@aycabta
Suppress warning; unused variable
74a6124
@aycabta
Use background color instead of border frame
8f1db0a
@aycabta
Add comments about where rerendering
4406069
@aycabta
Move cursor to rerender right margin of dialog correctly
5548550
@aycabta
Clear after cursor
4d7503c
@aycabta
Remove debug code
2389d17
@aycabta
Hide cursor when rendering dialog
a9050cf
@aycabta
Support hide/show cursor on Windows
0c87081
@aycabta
Move dialog pos to left when goes beyond right edge
f1efa2b
@aycabta
Scroll properly to create margin
064d54f
@aycabta
Display autocomplete below original line if end point was wrapped
49f3392
@aycabta
Drop too much contents before processing
94f7027
@aycabta
Combine vertical processing into @dialog_vertical_offset
600b936
@aycabta
Remove unnecessary metadata between lines
8392824
@aycabta
Show autocomplete correctly when starts from prev line
f31a76f
@aycabta
Update dialog backup before clearing
a39e2c8
@aycabta
Move cursor correctly when current line is auto wrapped
14c8fad
@aycabta
Fix typo
6370353
@aycabta
Completion journey starts with one of candidates
ccb70cc 
First one is just original string.
@aycabta
Remove unnecessary condition
07e911e
@aycabta
Implement dynamic selection of candidates
e46437d
@aycabta
Remove @dialog_updown and @dialog_contents_width
458cb8a
@aycabta
Cut out the autocomplete callback
46aa269
@aycabta
Support for multiple dialog rendering
f589fab
@aycabta
Add the ability to handle context between dialogs
063d9c7
@aycabta
Implement doc display dialog in conjunction with autocomplete
e97bbc4
@aycabta
Show method or class doc correctly
a505294
@aycabta aycabta merged commit 8586243 into ruby:master Aug 29, 2021
@aycabta aycabta deleted the implement-dialog branch August 29, 2021 11:06
This was referenced Aug 29, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aycabta