Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement vi_kill_line_prev #345

Merged
merged 1 commit into from
Sep 26, 2021
Merged

Implement vi_kill_line_prev #345

merged 1 commit into from
Sep 26, 2021

Conversation

jez
Copy link
Contributor

@jez jez commented Sep 9, 2021

This operation is mentioned and bound to ^U in both vi_command.rb
and vi_insert.rb, but there is no definition of it.

Both Vi and Emacs use the same keystroke to do the same behavior, so
I've chosen to use alias_method to make the implementation small,
rather than duplicating the method and re-implementing it.

This operation is mentioned and bound to `^U` in both `vi_command.rb`
and `vi_insert.rb`, but there is no definition of it.

Both Vi and Emacs use the same keystroke to do the same behavior, so
I've chosen to use `alias_method` to make the implementation small,
rather than duplicating the method and re-implementing it.
@jez
Copy link
Contributor Author

jez commented Sep 9, 2021

This is the behavior I see before making this change:

Screen Shot 2021-09-09 at 3 43 37 PM

But after I make this change, I see that ^U works.

If you'd like me to write a proper test for this, I can look into how to do that, but I would love suggestions on where to put it.

@aycabta
Copy link
Member

aycabta commented Sep 26, 2021

Thank you so much! CI failed, but this is a problem that has been resolved in master.

@aycabta aycabta merged commit c30aeca into ruby:master Sep 26, 2021
@jez jez deleted the jez-vi-kill-line-prev branch March 6, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants