Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: test_yamatanooroti fix #420

Merged
merged 1 commit into from
Jan 6, 2022
Merged

windows: test_yamatanooroti fix #420

merged 1 commit into from
Jan 6, 2022

Conversation

YO4
Copy link
Contributor

@YO4 YO4 commented Jan 3, 2022

Because of console geometry, SetConsoleScreenBufferSize() fails in yamatanooroti/windows.rb

SetConsoleScreenBufferSize() fails at too narrow console size (in pixel).
Bigger font resolv this, but screen height limit is other probrem.
1080lines screen needs this patch, 1440lines screen not

With this patch and yamatanootori head,
ruby 3.0.3p157 (2021-11-24 revision 3fb7d2cadc) [x64-mingw32] passed test_yamatanooroti with

Finished in 315.1460539 seconds.
------------------------------------------------------------------------------------------------------------------------
76 tests, 74 assertions, 0 failures, 0 errors, 0 pendings, 2 omissions, 0 notifications
100% passed
------------------------------------------------------------------------------------------------------------------------
0.24 tests/s, 0.23 assertions/s

but ruby 2.7 yet (probably dialog and windows last column write behavior)

windows can't create too narrow and tall window.
@aycabta aycabta merged commit cb95b46 into ruby:master Jan 6, 2022
@aycabta
Copy link
Member

aycabta commented Jan 6, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants