-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Unicode 15.0.0 #437
Conversation
Could you add tests? |
Sorry, I don't know what kind of testing is required... This file was mechanically generated by the script that comes with Reline (reline/generate_east_asian_width), and it seems unlikely that the generated code would be broken if not for a bug in the script. Also, no specific test code seems to have been created in past updates of EastAsianWidth.txt. This also seems to be true for Ruby. So, for this PR, I think there is little need for a test case beyond regression testing. Or does anyone have any ideas as to what kind of testing is needed? |
By the way, Unicode 15.0.0 will be released soon, making this PR obsolete... |
Unicode 15.0 is already merged at ruby core. FYI https://bugs.ruby-lang.org/issues/18639 Should we use Unicode 15.0 instead of 14.0 on |
@hsbt Reline's Unicode support is for character width(especially east asian width), so it must be supported separately from the Ruby core. |
@ima1zumi I didn't say how organize them. Just what's version should we use? |
@hsbt If this file is not updated, the widths of characters added after Unicode 14.0.0, such as Emojis, will not be obtained correctly. However, I do not know how to update this file at present. |
This is not rush thing. We can update this for Ruby 3.2.1 or others. |
As you are discussing, I don't think many people will be troubled if Reline stays at 13.0.0. By the way, I would like to update this PR to 15.0.0. |
That would be great. Thank you! |
I have updated to 15.0.0 by ba89e85 . (commit date was 3 months ago...) |
Looks good to me 🌟
My terminal (Alacritty 0.10.0-dev (8cda3d14)) is not displaying 🫢️ width correctly, but |
(ruby/reline#437) * Update to Unicode 14.0.0 * Update to Unicode 15.0.0
Ruby core has updated UCD version based on Unicode 14.0.0.
Following this, I updated Reline's East Asian Width table to Unicode 14.0.0 based.