Fix misuse of kwarg in IO#raw #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Obviously, `tim` is a typo for `time` - This didn't cause an exception because IO#raw is implemented in C and it doesn't check the keyword of the parameters - Though this typo doesn't produce any problems for now, I think it should be fixed just in case for the future - I've used this fixed version of Reline with IRB for several days and didn't find any new problems due to the fix - But I myself am not sure how to make sure this fix is completely robust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timis a typo fortime. see https://github.com/ruby/ruby/blob/v3_1_3/ext/io/console/console.c#L1637tim: 0is not inconsistent with thetime's default value0. see https://github.com/ruby/ruby/blob/v3_1_3/ext/io/console/console.c#L147