Fix dialog corrupts rendering by pushing up input line too much #524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix this redering corrupt bug.
Left: before, Right: after
dialog_range.mp4
Problem
If the terminal height is 5
Reline can only render 3 lines of dialog if the cursor is on line 2.
If reline breaks this rule and render 4 lines
Reline cannot move cursor to the beginning of line, where
if 1
was displayed.This is making reline's rendering corrupt.
I changed dialog rendering not to render where it overflows screen.