Run IRB test in workflow #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
reviewed
Apr 12, 2023
Co-authored-by: Stan Lo <stan001212@gmail.com>
st0012
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reverted the change I made in #533 that removed irb-test from workflow.
I also fixed the bug in irb-test workflow. It was running reline's test instead of irb's test.
cd irbis missing andbundle exec rake testwas running in the wrong directory.I also add irb's test_yamatanooroti in the workflow
Example of wrong test. 3068 assertions with different encoding is reline's test.
https://github.com/ruby/reline/actions/runs/4678386950/jobs/8287060129?pr=532