Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change readline test download source from ruby/ruby to ruby/readline-ext #540

Merged
merged 1 commit into from
May 10, 2023

Conversation

tompng
Copy link
Member

@tompng tompng commented May 9, 2023

ext/readline is removed from ruby/ruby ruby/ruby#7781

This pull request changes the download source path of ext/readline's test.

(maybe we can have readline test in reline's repository instead of downloading it, or just remove it #539)

@ima1zumi
Copy link
Member

ima1zumi commented May 9, 2023

readline-ext is no longer a bundled gem. But we can still install it, so this looks better than #539 👍

Copy link
Member

@ima1zumi ima1zumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ima1zumi ima1zumi merged commit 6b71376 into ruby:master May 10, 2023
@tompng tompng deleted the fix/readline-test-download-path branch May 10, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants