Fix [nil] is passed to auto_indent_proc when exit with CTRL+d

[osyo-manga]

Fix it #556
auto_indent_proc will argument ["] instead of [nil].

[tompng]

It seems [nil] is passed to auto_indent_proc only when Ctrl+d is pressed with empty input. In that case, I think reline doesn't need to call auto_indent_proc at all.

Could you investigate why auto_indent_proc is called and can the call be skipped? If it's hard for us to fix auto_indent_proc call, I think this fix is good and can be merged.

[osyo-manga]

@tompng hi.

Could you investigate why auto_indent_proc is called and can the call be skipped? If it's hard for us to fix auto_indent_proc call, I think this fix is good and can be merged.

If C-d is entered, #finish is called here to finish the process.

reline/lib/reline/line_editor.rb

Lines 2601 to 2608 in 2503ddb

	if @line.empty? and (not @is_multiline or @buffer_of_lines.size == 1) and key == "\C-d".ord
	@line = nil
	if @buffer_of_lines.size > 1
	scroll_down(@highest_in_all - @first_line_started_from)
	end
	Reline::IOGate.move_cursor_column(0)
	@eof = true
	finish

So the simple modification is as follows.

diff --git a/lib/reline/line_editor.rb b/lib/reline/line_editor.rb
index 7ad56a3..5b98df0 100644
--- a/lib/reline/line_editor.rb
+++ b/lib/reline/line_editor.rb
@@ -1605,7 +1605,7 @@ class Reline::LineEditor
     else
       @just_cursor_moving = false
     end
-    if @is_multiline and @auto_indent_proc and not simplified_rendering?
+    if @is_multiline and @auto_indent_proc and not simplified_rendering? and not finished?
       process_auto_indent
     end
   end

However, #finished? returns true even when exiting outside of C-d.
So there is a possibility that auto_indent_proc will not be called even if the program terminates outside of C-d.

[tompng]

When auto_indent_proc returns non-zero value

require 'reline'
Reline.auto_indent_proc=->(*){2}
Reline.readmultiline('>'){true}

process_auto_indent fails in this line.

reline/lib/reline/line_editor.rb

Line 1673 in 2503ddb

@line = ' ' * new_indent + @line.lstrip

We need to find a way to skip calling process_auto_indent.

Thanks for investigating and description about finished?. Yes, we need to recalculate indent in normal finished case.
How about adding and @line instead of and not finished?

[osyo-manga]

@tompng OK, Fixed it. Thanks.
osyo-manga@b203474

[tompng]

👍