Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When input line is very long, for example, after pasting
[1,1,1,1,1,1,1,1,...(thousands of items)...,1,1,1]
to IRB, Some cursor move operation and rendering is slow.Performance of pasting long text will be improved in bracketed-paste #655.
This pull request improves performance of re-rendering long text.
Reproduce
ed_move_to_end
I just forgot to erase the old while loop.
split_by_width
When the input is
1,1,1,1,1,1,1....
, colorized code will be[BLUE]1[RESET],[BLUE]1[RESET],...
Reline::Unicode.split_by_width will split into
This is because split_by_width does not understand actual CSI sequence and just concats it.
We can clear the concatenated sequences if the CSI is
"\e[m"
or"\e[0m"
that resets color and text style.