Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prompt width calculation bug #695

Merged
merged 1 commit into from
May 2, 2024
Merged

Fix prompt width calculation bug #695

merged 1 commit into from
May 2, 2024

Conversation

tompng
Copy link
Member

@tompng tompng commented May 1, 2024

Fix this bug (reline-0.5.3). Prompt width calculation was wrong when it contains escape sequence.
prompt_miscalculation_wordwrap_bug

@ima1zumi ima1zumi added the bug Something isn't working label May 2, 2024
ima1zumi
ima1zumi approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@ima1zumi ima1zumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ima1zumi ima1zumi merged commit 24aab01 into ruby:master May 2, 2024
40 checks passed
matzbot pushed a commit to ruby/ruby that referenced this pull request May 2, 2024
@tompng @matzbot
[ruby/reline] Fix prompt width calculation bug. Test with colored
eb82ea6 
prompt
(ruby/reline#695)

ruby/reline@24aab01cbc
@tompng tompng deleted the colored_prompt_bugfix branch May 2, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ima1zumi ima1zumi ima1zumi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tompng @ima1zumi