Rerender and enter raw mode again by SIGCONT #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ima1zumi
reviewed
Jun 25, 2024
| @old_cont_handler = Signal.trap('CONT') do | ||
| @input.raw!(intr: true) if @input.tty? | ||
| # Rerender the screen. Note that screen size might be changed while suspended. | ||
| handler.call |
There was a problem hiding this comment.
📝 Set @resized to true using set_signal_handlers, and rerender with handle_resized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reline is suspended by Ctrl-z and then resumed by fg command, reline needs to rerender the screen.
STDIN.raw/cooked is reset, so we need to call
raw!.Calling winch handler on SIGCONT because window might be resized while suspended. In that case, WINCH handler won't be called.