Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fiddle runtime dependency #762

Closed
wants to merge 1 commit into from

Conversation

AlexWayfer
Copy link

Resolve Ruby warning:

/home/alex/.rbenv/versions/3.3.5/lib/ruby/3.3.0/reline.rb:9: warning: fiddle was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.

(I've tried to add t.warning = true for Rake::TestTask, but it didn't help)

Resolve Ruby warning:
```
/home/alex/.rbenv/versions/3.3.5/lib/ruby/3.3.0/reline.rb:9: warning: fiddle was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
```
@AlexWayfer
Copy link
Author

The same CI fail as in master.

@tompng
Copy link
Member

tompng commented Oct 13, 2024

Test failure is fixed by ruby/irb#1016

Thank you for your pull request, but we can't add fiddle as a dependency. Discussion is in #344 and #718
Instead of adding to dependency, we now have warning suppression #721
We reduced the dependency to fiddle (#569 #722).
In non-windows environment, fiddle is actually not important. It just enables few keys (pgup, pgdown, delete_right_char). Even without fiddle, Reline mostly work as expected.

I think what we need to do in the future (before ruby 3.5) is:

  • Windows: force require fiddle (like Binding#irb is doing in ruby 3.4) or show an instruction message when require fails
  • Non-windows: Leave it as it is, or completely remove dependency to fiddle

@tompng tompng closed this Oct 13, 2024
@AlexWayfer
Copy link
Author

AlexWayfer commented Oct 13, 2024

OK, thanks. And sorry, I was searching for existing issues by my warning output, but hasn't found any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants