-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential Typo in REXML::Functions::normalize_space()
Implementation
#110
Comments
Good catch! |
flatland001
added a commit
to flatland001/rexml
that referenced
this issue
Feb 7, 2024
Replaced the variable 'string' with 'x' inside the collect block.
flatland001
added a commit
to flatland001/rexml
that referenced
this issue
Feb 7, 2024
…y#110 to validate `REXML::Functions::normalize_space()` functionality
flatland001
added a commit
to flatland001/rexml
that referenced
this issue
Feb 7, 2024
flatland001
added a commit
to flatland001/rexml
that referenced
this issue
Feb 8, 2024
Renamed test_normalize_space2 for better clarity and updated tests to use Array of String for expected data. ruby#110 Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
kou
added a commit
that referenced
this issue
Feb 8, 2024
GitHub: fix GH-110 Fixed a bug in `REXML::Functions.normalize_space(array)` and introduced test cases for it: - Corrected a typo in the variable name within the collect block (`string` -> `x`). - Added `test_normalize_space_strings` to `test/functions/test_base.rb`. --------- Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello Ruby/REXML developers,
The implementation can be found here:
https://github.com/ruby/rexml/blob/7e4049f6a68c99c4efec2df117057ee080680c9f/lib/rexml/functions.rb#L265C1-L273C8
The current code is as follows:
It appears there may be a typo in the use of
x
versusstring
within thecollect
block. I believe the following adjustment might be more in line with the intended functionality:I might be misunderstanding the intention here, so if I've overlooked something, please do let me know.
Thank you for your time.
The text was updated successfully, but these errors were encountered: