Comment lines can be placed between fluent dot now

ruby · Sep 15, 2019 · 3a3f48f · 3a3f48f
1 parent 751d4ab
commit 3a3f48f
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/NEWS b/NEWS
@@ -71,6 +71,12 @@ sufficient information, see the ChangeLog file or Redmine
 
 * The flip-flop syntax deprecation is reverted. [Feature #5400]
 
+* Comment lines can be placed between fluent dot now.
+
+    foo
+      # .bar
+      .baz # => foo.baz
+
 === Core classes updates (outstanding ones only)
 
 Complex::

diff --git a/parse.y b/parse.y
@@ -8737,6 +8737,10 @@ parser_yylex(struct parser_params *p)
 	      case '\13': /* '\v' */
 		space_seen = 1;
 		break;
+	      case '#':
+		pushback(p, c);
+		if (space_seen) dispatch_scan_event(p, tSP);
+		goto retry;
 	      case '&':
 	      case '.': {
 		dispatch_delayed_token(p, tIGNORED_NL);

diff --git a/test/ruby/test_syntax.rb b/test/ruby/test_syntax.rb
@@ -1033,6 +1033,9 @@ def test_fluent_dot
     assert_valid_syntax("a\n.foo")
     assert_valid_syntax("a\n&.foo")
     assert_valid_syntax("a\n.:foo")
+    assert_valid_syntax("a #\n#\n.foo\n")
+    assert_valid_syntax("a #\n#\n&.foo\n")
+    assert_valid_syntax("a #\n#\n.:foo\n")
   end
 
   def test_safe_call_in_massign_lhs