Removed Random::Formatter

[hsbt]

This is another try with #29

[jdelStrother]

FWIW I think this causes problems with Rails on ruby 3.2.

Rails was using SecureRandom.alphanumeric here - https://github.com/rails/rails/blob/4060253ea7bf1a04c7b2368ffc17ddcf991997f9/activesupport/lib/active_support/core_ext/securerandom.rb#L20, but now throws wrong number of arguments (given 2, expected 0..1).

With the removal of SecureRandom.alphanumeric, that falls back to Random.alphanumeric. On ruby 3.2, that only accepts a single argument:

  def alphanumeric(n=nil)
    n = 16 if n.nil?
    choose(ALPHANUMERIC, n)
  end

[nevans]

As far as I can tell, the only functional changes to Random::Formatter between v0.2.0 (which was installed with ruby 3.1.6) and v0.3.2 are:

• #alphanumeric keyword arg for characters (which affects Rails, as @jdelStrother mentioned)
• #uuid_v7 (and #uuid_v4 alias)

$ rbenv shell 3.2.6
$ gem install securerandom -v0.3.2
Fetching securerandom-0.3.2.gem
Successfully installed securerandom-0.3.2
Parsing documentation for securerandom-0.3.2
Installing ri documentation for securerandom-0.3.2
Done installing documentation for securerandom after 0 seconds
1 gem installed
$ ruby -rsecurerandom -e "puts SecureRandom.uuid_v7"
0193889a-f355-76b5-bff8-9e46efa743d0
$ gem install securerandom -v0.4.0
Fetching securerandom-0.4.0.gem
Successfully installed securerandom-0.4.0
Parsing documentation for securerandom-0.4.0
Installing ri documentation for securerandom-0.4.0
Done installing documentation for securerandom after 0 seconds
1 gem installed
$ ruby -rsecurerandom -e "puts SecureRandom.uuid_v7"
-e:1:in `<main>': undefined method `uuid_v7' for SecureRandom:Module (NoMethodError)

puts SecureRandom.uuid_v7
                 ^^^^^^^^
Did you mean?  uuid

[hsbt]

@jdelStrother @nevans Thank you for sharing that. I and @nobu couldn't care these cases before removing Random::Formatter. I'll consider them with compatibility.

[nevans]

@hsbt Would it be possible (this close to the 3.4 release) to create a new random-formatter gem? For full backward compatibility, it should be an explicit dependency of securerandom. I created a proof-of-concept here: https://github.com/nevans/securerandom/tree/random-formatter. It shouldn't be merged into this repo, so I won't create a PR. But here's the diff, for comparison: master...nevans:securerandom:random-formatter