Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec: Struct#keyword_init? #948

Closed
wants to merge 1 commit into from

Conversation

ohbarye
Copy link
Contributor

@ohbarye ohbarye commented Oct 7, 2022

Issue

A part of #947 #923

Changes

I'm trying to cover the following part of the issue.

StructClass#keyword_init? is added [Feature #18008]


BTW, this tweet encouraged me to create this pull request.

Please tell me if anything is wrong with this pull request since I'm almost new to contribution to this project!

@eregon
Copy link
Member

eregon commented Oct 8, 2022

Thank you for the PR.
Unfortunately I already merged #953 before seeing this one, I am sorry.
Maybe you can pick another spec? Feel free to mention it on #947 to avoid conflicts.

@eregon eregon closed this Oct 8, 2022
@eregon
Copy link
Member

eregon commented Oct 8, 2022

FWIW I tried to process my emails in order but somehow I missed this one, sorry.

@ohbarye ohbarye deleted the add-struct-keyword_init-spec branch October 8, 2022 13:02
@ohbarye
Copy link
Contributor Author

ohbarye commented Oct 8, 2022

@eregon No worries!
I'll try another one and will mention my target in the issue. 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants